Post-merge review of #2408 (template-no-autofocus-attribute)#2496
Merged
NullVoxPopuli merged 6 commits intoember-cli:masterfrom Mar 13, 2026
Merged
Post-merge review of #2408 (template-no-autofocus-attribute)#2496NullVoxPopuli merged 6 commits intoember-cli:masterfrom
template-no-autofocus-attribute)#2496NullVoxPopuli merged 6 commits intoember-cli:masterfrom
Conversation
…tofix
- Add GlimmerMustacheStatement visitor for {{input autofocus=true}}
- Change fixable to null (matching original's deliberate design choice)
- Add test cases for mustache form, div, h1, input autofocus="autofocus"
The original isFixable:false was just a documentation tag, not a design
choice. Restore the fixer for element attributes while keeping the new
MustacheStatement handler for {{input autofocus=true}} patterns.
NullVoxPopuli
approved these changes
Mar 13, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing
MustacheStatementvisitor. The original handles bothElementNodeandMustacheStatement(for{{input autofocus=true}}). The extraction only hadElementNode, so{{input autofocus=true}}and{{component "input" autofocus=true}}silently passed.Cowritten by claude